lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 009/127] atm: fix info leak in getsockopt(SO_ATMPVC)
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit e862f1a9b7df4e8196ebec45ac62295138aa3fc2 ]

    The ATM code fails to initialize the two padding bytes of struct
    sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
    before filling the structure to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/atm/common.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/atm/common.c
    +++ b/net/atm/common.c
    @@ -784,6 +784,7 @@ int vcc_getsockopt(struct socket *sock,

    if (!vcc->dev || !test_bit(ATM_VF_ADDR, &vcc->flags))
    return -ENOTCONN;
    + memset(&pvc, 0, sizeof(pvc));
    pvc.sap_family = AF_ATMPVC;
    pvc.sap_addr.itf = vcc->dev->number;
    pvc.sap_addr.vpi = vcc->vpi;



    \
     
     \ /
      Last update: 2012-09-28 23:21    [W:4.279 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site