lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 103/218] hpwdt: Fix kdump issue in hpwdt
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Toshi Kani <toshi.kani@hp.com>

    commit 308b135e4fcc00c80c07e0e04e7afa8edf78583c upstream.

    kdump can be interrupted by watchdog timer when the timer is left
    activated on the crash kernel. Changed the hpwdt driver to disable
    watchdog timer at boot-time. This assures that watchdog timer is
    disabled until /dev/watchdog is opened, and prevents watchdog timer
    to be left running on the crash kernel.

    Signed-off-by: Toshi Kani <toshi.kani@hp.com>
    Tested-by: Lisa Mitchell <lisa.mitchell@hp.com>
    Signed-off-by: Thomas Mingarelli <Thomas.Mingarelli@hp.com>
    Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/watchdog/hpwdt.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/watchdog/hpwdt.c
    +++ b/drivers/watchdog/hpwdt.c
    @@ -806,6 +806,9 @@ static int __devinit hpwdt_init_one(stru
    hpwdt_timer_reg = pci_mem_addr + 0x70;
    hpwdt_timer_con = pci_mem_addr + 0x72;

    + /* Make sure that timer is disabled until /dev/watchdog is opened */
    + hpwdt_stop();
    +
    /* Make sure that we have a valid soft_margin */
    if (hpwdt_change_timer(soft_margin))
    hpwdt_change_timer(DEFAULT_MARGIN);



    \
     
     \ /
      Last update: 2012-09-28 23:21    [W:4.043 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site