lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib
On 13:32 Fri 28 Sep     , Roland Stigge wrote:
> On 09/28/2012 12:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> gpio0 = {1};
> >> set0 = {1};
> >>
> >> gpio1 = {33, 34};
> > here should be
> >
> > pin0 = {1};
> > set0 = {1};
> >
> > pin1 = {1, 2, 23};
> > set1 = {0, 0, 1};
> >
> > set_blocks(gpio_chip0, pin0, set0, 1);
> > set_blocks(gpio_chip1, pin1, set1, 3);
> >
> > You may need to add a prepare to do not do the conversion between array and
> > gpio_chip array as I guess you will work on gpio block with multiple time
> > acces
>
> Maybe like this, for some struct block *?
>
> block = set_block_prepare(gc, pins, values, size);
> if (block) {
> set_block(gc, block);
> ...
> set_block_unprepare(gc, block);
> }
>
> Would mean that all supported drivers would need to implement those 3
> new functions... Need to be careful about not introducing bloat...
the prepare is gpiolib specific, it will be a helper to conver a gpio list to
a gpio block list

I was thinking more

block = gpio_block_prepare(pins, size);

gpio_block_set_value(pin0, val);
gpio_block_set_value(pin1, val);
gpio_block_set_value(pin2, val);
gpio_block_set(block);

andfor get

gpio_block_get(block)
val = gpio_block_get_value(block, pin0);
val = gpio_block_get_value(block, pin1);

for the gpio driver ti's transparent

Best Regards,
J.


\
 
 \ /
  Last update: 2012-09-28 18:41    [W:0.064 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site