Messages in this thread | | | Date | Fri, 28 Sep 2012 14:10:43 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist |
| |
On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote: > The reclaim_clean_pages_from_list reclaims clean pages before > migration so cc.nr_migratepages should be updated. > Currently, there is no problem but it can be wrong if we > try to use the vaule in future. > > Cc: Mel Gorman <mgorman@suse.de> > Cc: Michal Nazarewicz <mina86@mina86.com> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Minchan Kim <minchan@kernel.org>
Yeah ok. As you say, it shouldn't actually affect anything currently and cc.migratepages is expected to go out of date after migration meaning we need update_nr_listpages. This patch looks ok though.
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
| |