lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 016/218] Bluetooth: RFCOMM - Fix info leak via getsockname()
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit 9344a972961d1a6d2c04d9008b13617bcb6ec2ef ]

    The RFCOMM code fails to initialize the trailing padding byte of struct
    sockaddr_rc added for alignment. It that for leaks one byte kernel stack
    via the getsockname() syscall. Add an explicit memset(0) before filling
    the structure to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Cc: Marcel Holtmann <marcel@holtmann.org>
    Cc: Gustavo Padovan <gustavo@padovan.org>
    Cc: Johan Hedberg <johan.hedberg@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/bluetooth/rfcomm/sock.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/bluetooth/rfcomm/sock.c
    +++ b/net/bluetooth/rfcomm/sock.c
    @@ -546,6 +546,7 @@ static int rfcomm_sock_getname(struct so

    BT_DBG("sock %p, sk %p", sock, sk);

    + memset(sa, 0, sizeof(*sa));
    sa->rc_family = AF_BLUETOOTH;
    sa->rc_channel = rfcomm_pi(sk)->channel;
    if (peer)



    \
     
     \ /
      Last update: 2012-09-29 04:41    [W:4.208 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site