Messages in this thread | | | From | Ramesh Nagappa <> | Date | Fri, 28 Sep 2012 20:26:51 -0400 | Subject | RE: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic |
| |
> > Why is all of this in the middle of the changelog section? > > I'm guessing you didn't use 'git send-email' for this? > > And why are you copying me on the patch?
I got the CC list from scripts/get_maintainers.pl
asglx-2-300 $ scripts/get_maintainer.pl 0001-net-fix-neigh_resolve_output-can-cause-skb_under_pan.patch "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL],commit_signer:3/4=75%) Greg Kroah-Hartman <gregkh@linuxfoundation.org> (commit_signer:3/4=75%) Eric Dumazet <eric.dumazet@gmail.com> (commit_signer:2/4=50%) Shawn Lu <shawn.lu@ericsson.com> (commit_signer:1/4=25%) Michel Machado <michel@digirati.com.br> (commit_signer:1/4=25%) netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) linux-kernel@vger.kernel.org (open list)
> > > You need a blank line before the first Signed-off-by: line. > Surely one of the reviewers should have caught this basic thing?
Outlook mangled the patch. I am unable to use git send-email because of a corporate firewall on the build machine.
> > greg k-h >
Thanks, Ramesh
| |