lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 138/218] usb: host: xhci: fix compilation error for non-PCI based stacks
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Moiz Sonasath <m-sonasath@ti.com>

    commit 296365781903226a3fb8758901eaeec09d2798e4 upstream.

    For non PCI-based stacks, this function call
    usb_disable_xhci_ports(to_pci_dev(hcd->self.controller));
    made from xhci_shutdown is not applicable.

    Ideally, we wouldn't have any PCI-specific code on
    a generic driver such as the xHCI stack, but it looks
    like we should just stub usb_disable_xhci_ports() out
    for non-PCI devices.

    [ balbi@ti.com: slight improvement to commit log ]

    This patch should be backported to kernels as old as 3.0, since the
    commit it fixes (e95829f474f0db3a4d940cae1423783edd966027 "xhci: Switch
    PPT ports to EHCI on shutdown.") was marked for stable.

    Signed-off-by: Moiz Sonasath<m-sonasath@ti.com>
    Signed-off-by: Ruchika Kharwar <ruchika@ti.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/pci-quirks.h | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/host/pci-quirks.h
    +++ b/drivers/usb/host/pci-quirks.h
    @@ -15,6 +15,7 @@ void usb_disable_xhci_ports(struct pci_d
    static inline void usb_amd_quirk_pll_disable(void) {}
    static inline void usb_amd_quirk_pll_enable(void) {}
    static inline void usb_amd_dev_put(void) {}
    +static inline void usb_disable_xhci_ports(struct pci_dev *xhci_pdev) {}
    #endif /* CONFIG_PCI */

    #endif /* __LINUX_USB_PCI_QUIRKS_H */



    \
     
     \ /
      Last update: 2012-09-29 01:01    [W:3.281 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site