lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 011/218] atm: fix info leak via getsockname()
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a ]

    The ATM code fails to initialize the two padding bytes of struct
    sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
    before filling the structure to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/atm/pvc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/atm/pvc.c
    +++ b/net/atm/pvc.c
    @@ -95,6 +95,7 @@ static int pvc_getname(struct socket *so
    return -ENOTCONN;
    *sockaddr_len = sizeof(struct sockaddr_atmpvc);
    addr = (struct sockaddr_atmpvc *)sockaddr;
    + memset(addr, 0, sizeof(*addr));
    addr->sap_family = AF_ATMPVC;
    addr->sap_addr.itf = vcc->dev->number;
    addr->sap_addr.vpi = vcc->vpi;



    \
     
     \ /
      Last update: 2012-09-29 01:01    [W:4.041 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site