Messages in this thread | | | Date | Thu, 27 Sep 2012 15:52:10 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] slab: Ignore internal flags in cache creation |
| |
On Thu, 27 Sep 2012, Christoph Lameter wrote:
> > > > Nack, this is already handled by CREATE_MASK in the mm/slab.c allocator; > > > > > > CREATE_MASK defines legal flags that can be specified. Other flags cause > > > and error. This is about flags that are internal that should be ignored > > > when specified. > > > > > > > That should be ignored for the mm/slab.c allocator, yes. > > Then you are ok with the patch as is? >
No, it's implementation defined so it shouldn't be in kmem_cache_create(), it should be in __kmem_cache_create().
> There *are* multiple slab allocators using those bits! And this works for > them. There is nothing too restrictive here. The internal flags are > standardized by this patch to be in the highest nibble. >
I'm referring to additional slab allocators that will be proposed for inclusion shortly.
| |