lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] kpageflags: fix wrong KPF_THP on non-huge compound pages
On Wed, 26 Sep 2012, Naoya Horiguchi wrote:

> diff --git v3.6-rc6.orig/fs/proc/page.c v3.6-rc6/fs/proc/page.c
> index 7fcd0d6..b8730d9 100644
> --- v3.6-rc6.orig/fs/proc/page.c
> +++ v3.6-rc6/fs/proc/page.c
> @@ -115,7 +115,13 @@ u64 stable_page_flags(struct page *page)
> u |= 1 << KPF_COMPOUND_TAIL;
> if (PageHuge(page))
> u |= 1 << KPF_HUGE;
> - else if (PageTransCompound(page))
> + /*
> + * PageTransCompound can be true for non-huge compound pages (slab
> + * pages or pages allocated by drivers with __GFP_COMP) because it
> + * just checks PG_head/PG_tail, so we need to check PageLRU to make
> + * sure a given page is a thp, not a non-huge compound page.
> + */
> + else if (PageTransCompound(page) && PageLRU(compound_trans_head(page)))
> u |= 1 << KPF_THP;
>
> /*

Yes, that looks good. Nice catch by Fengguang.


\
 
 \ /
  Last update: 2012-09-27 03:41    [W:0.062 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site