Messages in this thread | | | Date | Wed, 26 Sep 2012 23:27:10 +0200 | From | Peter Stuge <> | Subject | Re: [Patch v5] ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc |
| |
Rene Buergel wrote: > - renamed CONFIG_USB_EZUSB to CONFIG_USB_EZUSB_FX2 to avoid build errors
Is this really the reason for the build error? I doubt it.
Also, does the code in fact support only FX2, neither older chips nor newer FX3?
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 1bfcd02..bf7dc43 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -244,3 +244,8 @@ config USB_YUREX > To compile this driver as a module, choose M here: the > module will be called yurex. > > +config USB_EZUSB_FX2 > + tristate "Functions for loading firmware on EZUSB chips"
If only FX2 then I suggest mentioning that also in the immediately user-visible option description, not only in the help.
> + help > + Say Y here if you need EZUSB device support. > + (Cypress FX/FX2/FX2LP microcontrollers)
If FX is also supported then perhaps still rename the option, although I think renaming is unrelated to the build problems.
I think it makes sense to call the option after the "highest" supported chip.
//Peter
| |