Messages in this thread | | | Date | Wed, 26 Sep 2012 14:09:15 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH/RFC/cosmetic] driver base: use available pointer |
| |
On Mon, Sep 24, 2012 at 11:48:28AM +0200, Guennadi Liakhovetski wrote: > Don't recalculate an available pointer. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > --- > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index a1a7225..efe9aa9 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -166,8 +166,8 @@ static void platform_device_release(struct device *dev) > struct platform_object *pa = container_of(dev, struct platform_object, > pdev.dev); > > - of_device_node_put(&pa->pdev.dev); > - kfree(pa->pdev.dev.platform_data); > + of_device_node_put(dev); > + kfree(dev->platform_data);
If you don't mind, I'll leave it as-is, as it makes it a bit more obvious as to exactly what we are cleaning up here.
thanks,
greg k-h
| |