lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: linux-next: build failure after merge of the akpm tree
On Wed, 26 Sep 2012 13:42:05 -0700
Kees Cook <keescook@chromium.org> wrote:

> > +static inline int audit_get_loginuid(struct task_struct *tsk)
>
> Shouldn't this return kuid_t, due to "userns: Convert the audit
> loginuid to be a kuid"?

yup, thanks.

--- a/include/linux/audit.h~audith-replace-defines-with-c-stubs-fix
+++ a/include/linux/audit.h
@@ -530,7 +530,7 @@ extern int auditsc_get_stamp(struct audi
struct timespec *t, unsigned int *serial);
extern int audit_set_loginuid(kuid_t loginuid);

-static inline int audit_get_loginuid(struct task_struct *tsk)
+static inline kuid_t audit_get_loginuid(struct task_struct *tsk)
{
return tsk->loginuid
}
@@ -677,7 +677,7 @@ static inline int auditsc_get_stamp(stru
{
return 0;
}
-static inline int audit_get_loginuid(struct task_struct *tsk)
+static inline kuid_t audit_get_loginuid(struct task_struct *tsk)
{
return INVALID_UID;
}
_


\
 
 \ /
  Last update: 2012-09-26 23:21    [W:0.033 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site