Messages in this thread | | | Date | Wed, 26 Sep 2012 11:07:11 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 01/12] workqueue: add WORKER_RESCUER |
| |
On Thu, Sep 27, 2012 at 01:20:32AM +0800, Lai Jiangshan wrote: > rescuer thread must be a worker which is WORKER_NOT_RUNNING: > If it is *not* WORKER_NOT_RUNNING, it will increase the nr_running > and it disables the normal workers wrongly. > > So rescuer thread must be WORKER_NOT_RUNNING. > > Currently code implement it by always setting WORKER_PREP on rescuer thread, > but this kind of implement is ugly: > A) It reuses WORKER_PREP which is used for a different meaning. > B) It does not told us rescuer thread is WORKER_NOT_RUNNING. > > So we add WORKER_RESCUER to fix these two sematic.
Ah, right, we always have WORKER_PREP set for rescuers. So, this doesn't actually change the behavior at all? I'm not necessarily against it but the commit message seems a bit misleading.
Thanks.
-- tejun
| |