lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/10] workqueue: restructure flush_workqueue() and start all flusher at the same time
Hello, again.

On Wed, Sep 26, 2012 at 09:49:58AM -0700, Tejun Heo wrote:
> > The simple version of flush_workqueue() which I sent yesterday is "chained",
> > because it forces overflow flushers wait for free color and forces only one
> > flusher for one color.
> >
> > Since "not chaining" is important/essential. I sent a new draft implement today.
> > it uses multiple queues, one for each color(like SRCU).
> > this version is also simple, it remove 90 LOC.
>
> I'll review your patch but the current implementation is enough on
> that regard. I was trying to advise against going for two-color
> scheme.

So, I like it. Two things.

* I think we still want to optimize noop case. IOW, please keep the
early exit path for cases where there's no work item to flush.

* Can you please redo the patch series so that it doesn't go too much
roundabout?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-09-26 19:41    [W:0.051 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site