lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pagemap: fix wrong KPF_THP on slab pages
Date
On Wed, Sep 26, 2012 at 12:02:34AM -0400, Naoya Horiguchi wrote:
...
> > > + * page is a thp, not a non-huge compound page.
> > > + */
> > > + else if (PageTransCompound(page) && !PageSlab(page))
> > > u |= 1 << KPF_THP;
> >
> > Good catch!
> >
> > Will this report THP for the various drivers that do __GFP_COMP
> > page allocations?
>
> I'm afraid it will. I think of checking PageLRU as an alternative,
> but it needs compound_head() to report tail pages correctly.
> In this context, pages are not pinned or locked, so it's unsafe to
> use compound_head() because it can return a dangling pointer.
> Maybe it's a thp's/hugetlbfs's (not kpageflags specific) problem,
> so going forward with compound_head() expecting that it will be
> fixed in the future work can be an option.

It seems that compound_trans_head() solves this problem, so I'll
simply use it.

Naoya


\
 
 \ /
  Last update: 2012-09-26 08:41    [W:0.053 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site