lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: Work around old gas bug
>>> On 26.09.12 at 13:16, Ingo Molnar <mingo@kernel.org> wrote:

> * Jan Beulich <JBeulich@suse.com> wrote:
>
>> >>> On 26.09.12 at 10:28, Tao Guo <glorioustao@gmail.com> wrote:
>> > gas in binutils(2.16.91) could not parse parentheses within macro
>> > parameters unless fully parenthesized, and this is a workaround to
>> > make old gas work without generating below errors:
>> > arch/x86/kernel/entry_64.S: Assembler messages:
>> > arch/x86/kernel/entry_64.S:387: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:389: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:390: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:391: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:392: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:393: Error: too many positional arguments
>> > arch/x86/kernel/entry_64.S:394: Error: too many positional arguments
>> >
>> > Signed-off-by: Tao Guo <glorioustao@gmail.com>
>>
>> This looks okay now to me, but I'm somewhat reluctant to
>> formally ack it given that we know how broken those particular
>> gas versions are.
>
> Well, assuming Tao Guo test-booted a kernel build with this old
> GAS version, we could apply this patch on a best-effort basis -
> the changes don't look particularly ugly. If other, unacceptable
> uglies or fragilities come up then we might balk.
>
> Agreed?

Fine with me.

Jan



\
 
 \ /
  Last update: 2012-09-26 13:41    [W:0.046 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site