Messages in this thread | | | From | "Liu, Chuansheng" <> | Subject | RE: [PATCH RESEND] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask | Date | Wed, 26 Sep 2012 08:56:20 +0000 |
| |
> A return value of 0 and 1 are acceptable. So this check isn't correct. > > Regards, > Srivatsa S. Bhat > Which case value 1 is acceptable, could you share? Thanks.
> OMG, why did you drop the other hunk which cleared the cpu *before* > invoking ->irq_set_affinity()? IMO, altering irq affinity involves more work > than just altering the mask; that's why you have that ->irq_set_affinity() > function. So, if you alter the mask *after* calling ->irq_set_affinity(), > its not right.. Sorry the mistake, will update.
| |