lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] slab: Ignore internal flags in cache creation
On Tue, 25 Sep 2012, Christoph Lameter wrote:

> > No cache should ever pass those as a creation flags. We can just ignore
> > this bit if it happens to be passed (such as when duplicating a cache in
> > the kmem memcg patches)
>
> Acked-by: Christoph Lameter <cl@linux.com>
>

Nack, this is already handled by CREATE_MASK in the mm/slab.c allocator;
the flag extensions beyond those defined in the generic slab.h header are
implementation defined. It may be true that SLAB uses a bit only
internally (and already protects it with a BUG_ON() in
__kmem_cache_create()) but that doesn't mean other implementations can't
use such a flag that would be a no-op on another allocator.


\
 
 \ /
  Last update: 2012-09-26 03:21    [W:0.153 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site