Messages in this thread | | | Date | Tue, 25 Sep 2012 17:46:57 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] slab: Ignore internal flags in cache creation |
| |
On Tue, 25 Sep 2012, Christoph Lameter wrote:
> > No cache should ever pass those as a creation flags. We can just ignore > > this bit if it happens to be passed (such as when duplicating a cache in > > the kmem memcg patches) > > Acked-by: Christoph Lameter <cl@linux.com> >
Nack, this is already handled by CREATE_MASK in the mm/slab.c allocator; the flag extensions beyond those defined in the generic slab.h header are implementation defined. It may be true that SLAB uses a bit only internally (and already protects it with a BUG_ON() in __kmem_cache_create()) but that doesn't mean other implementations can't use such a flag that would be a no-op on another allocator.
| |