lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 memstick: support for legacy sony memsticks
From
Date
On Tue, 2012-09-25 at 11:02 -0700, Tejun Heo wrote: 
> Hello,
>
> > * Swithced to using a workqueue.
> > Unfortunelly, I still see that workqueue items are executed in parallel
> > I suspect that this happens if one work item sleeps. In this case I
> > don't want other work items to run too. I fixed this with a mutex, and anyway
> > it nice to have it to guaranteee this.
>
> You can use alloc_ordered_workqueue("namefmt", WQ_MEM_RECLAIM). No
> mutex needed for inter-work exclusion.
But this just adds the WQ_UNBOUND. Dunno, without lock I had several
crashes, that for high level of confidence caused by by parallel
execution of work items. Once I added this mutex, I couldnt reproduce
these.

I had the __blk_end_request fail with NULL msb->req. I can't see how
that can happen if work queue isn't executed in parallel.
(and then the I didn't even had by mistake the code that sets it to NULL
in msb_stop, so I really fail to see how that could happen due internal
bug in my code.
>
> Thanks.
>

--
Best regards,
Maxim Levitsky




\
 
 \ /
  Last update: 2012-09-25 22:21    [W:0.058 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site