lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] lxt PHY: Support for the buggy LXT973 rev A2

Le 24/09/2012 20:30, Richard Cochran a écrit :
> On Mon, Sep 24, 2012 at 04:00:58PM +0200, Christophe Leroy wrote:
>
>> diff -u a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c
>> --- a/drivers/net/phy/lxt.c 2012-09-23 03:08:48.000000000 +0200
>> +++ b/drivers/net/phy/lxt.c 2012-09-23 03:18:00.000000000 +0200
> ...
>
>> @@ -175,6 +292,16 @@
>> .driver = { .owner = THIS_MODULE,},
>> }, {
>> .phy_id = 0x00137a10,
>> + .name = "LXT973-A2",
>> + .phy_id_mask = 0xffffffff,
>> + .features = PHY_BASIC_FEATURES,
>> + .flags = 0,
>> + .probe = lxt973_probe,
>> + .config_aneg = lxt973_config_aneg,
>> + .read_status = lxt973a2_read_status,
> I like this way of matching the A2 chips much better than what you had
> before. But are you sure this will work correctly?
Apparently it does.
>
> What do A3 chips have in the last nibble of phy_id?

A2 chip has phy_id 0x00137a10
A3 chip has phy_id 0x00137a11

Christophe
>
>> + .driver = { .owner = THIS_MODULE,},
>> +}, {
>> + .phy_id = 0x00137a10,
>> .name = "LXT973",
>> .phy_id_mask = 0xfffffff0,
>> .features = PHY_BASIC_FEATURES,
> Thanks,
> Richard
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-09-25 09:01    [W:0.061 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site