Messages in this thread | | | Date | Tue, 25 Sep 2012 17:09:05 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 18/19] x86, io_apic: Introduce eoi_ioapic_pin call-back |
| |
On Sun, Aug 26, 2012 at 08:52:33PM +0200, Sebastian Andrzej Siewior wrote: > Basically you shuffle the code from up there, down there and call from behind > a function pointer. There are two things different this time: > - no version check >= 0x20 > I belive this is obsolete since this runs only on x86-64 with x(2)apic > support and assumes more or less version 0x20+ or we wouldn't be here at > all.
Right, all systems that have interrupt remapping have an io-apic version of 0x20 or higher.
> - the irq_remapped(cfg) check is gone. The cfg thing is per-interrupt basis > created so you _now_ you act like the interrupt is remapped even if it is > not. Or am I wrong here?
That comes from the fact that with the current implementation (with and without my patches) IO-APIC interrupts are always remapped. So it is safe to remove that check.
> > + > New line and the end? Why would that be?
Coding leftover, I'll remove that.
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |