Messages in this thread | | | Date | Tue, 25 Sep 2012 08:17:03 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file |
| |
Em Tue, Sep 25, 2012 at 04:20:53PM +0800, Feng Tang escreveu: > On Tue, 25 Sep 2012 11:11:21 +0900 > Namhyung Kim <namhyung@kernel.org> wrote: > > Ditto. Plus it might leak previous input_name. > > Nice catch, will check the return value of "strdup". > > For input_name mem leak, in some cases the input_name can't be called > with free(), like those got from parse "-i" option. In case the old > input_name is got from malloc through strdup, I think it's not a big > issue given that buffer will be freed any way when the application exit.
I think this is a matter of discipline, leaking is bad, kernel or userspace, why special case it?
- Arnaldo
| |