Messages in this thread | | | Date | Tue, 25 Sep 2012 13:57:11 +0200 | From | Ingo Molnar <> | Subject | Re: [BUG] perf/x86: Intel uncore_pmu_to_box() local variable typo |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, 2012-09-25 at 12:44 +0200, Stephane Eranian wrote: > > Hi, > > > > I don't understand why the local variable box needs to > > be declared static here: > > > > static struct intel_uncore_box * > > uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu) > > { > > static struct intel_uncore_box *box; > > > > box = *per_cpu_ptr(pmu->box, cpu); > > if (box) > > return box; > > .... > > } > > Uhmm.. me neither.. that looks like a bug indeed.
the compiler (or Sparse) should refuse function local statics really.
Thanks,
Ingo
| |