lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] perf/x86: Intel uncore_pmu_to_box() local variable typo

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, 2012-09-25 at 12:44 +0200, Stephane Eranian wrote:
> > Hi,
> >
> > I don't understand why the local variable box needs to
> > be declared static here:
> >
> > static struct intel_uncore_box *
> > uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu)
> > {
> > static struct intel_uncore_box *box;
> >
> > box = *per_cpu_ptr(pmu->box, cpu);
> > if (box)
> > return box;
> > ....
> > }
>
> Uhmm.. me neither.. that looks like a bug indeed.

the compiler (or Sparse) should refuse function local statics
really.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-09-25 14:41    [W:0.047 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site