lkml.org 
[lkml]   [2012]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8
2012/8/3 George Spelvin <linux@horizon.com>:
> If you're going to have a conditional branch after
> each 32x32->64-bit multiply, might as well shrink the code
> and make it a loop.
>
> This also avoids using the long multiply for small integers.
>
> (This leaves the comments in a confusing state, but that's a separate
> patch to make review easier.)
>
> Signed-off-by: George Spelvin <linux@horizon.com>

This patch breaks IP address printing with "%pI4" (and by extension,
nfsroot). Example:

- Before: 10.0.0.1
- After: 10...1


\
 
 \ /
  Last update: 2012-09-23 17:01    [W:0.192 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site