lkml.org 
[lkml]   [2012]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] pwm_backlight: Add device tree support for Low Threshold Brightness
Date
On Wed, Sep 19, 2012 at 12:14:25, Thierry Reding wrote:
> On Wed, Aug 01, 2012 at 06:51:21AM +0000, Philip, Avinash wrote:
> > On Mon, Jul 30, 2012 at 12:28:05, Thierry Reding wrote:
> > > On Wed, Jul 25, 2012 at 05:54:02PM +0530, Philip, Avinash wrote:
> > > > Low Threshold Brightness should be configured to have a linear relation
> > > > in brightness scale. This patch adds device tree support for low
> > > > threshold brightness as optional one for pwm_backlight.
> > >
> > > I think this should be more explicit as to why this is required, perhaps
> > > something like this:
> > >
> > > Some backlights perform poorly when driven by a PWM with a short
> > > duty-cycle. For such devices, the low threshold can be used to
> > > specify a lower bound for the duty-cycle and should be chosen to
> > > exclude the problematic range.
> > >
> > > This patch adds support for an optional low-threshold-brightness
> > > property.
[snip]
>
> I think you never sent an updated patch or maybe I missed it. But I
> noticed that this patch has now ended up in Andrew's tree without the
> comments being addressed. Can you please follow up?

I will send a revised patch.

Thanks
Avinash



\
 
 \ /
  Last update: 2012-09-21 07:21    [W:0.048 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site