Messages in this thread | | | Date | Thu, 20 Sep 2012 12:36:05 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH 3/6] x86, kvm: use kernel_fpu_begin/end() in kvm_load/put_guest_fpu() |
| |
On 09/19/2012 08:26 PM, H. Peter Anvin wrote: > On 09/19/2012 10:22 AM, Avi Kivity wrote: >> >> Note, we could also go in a different direction and make >> kernel_fpu_begin() use preempt notifiers and thus make its users >> preemptible. But that's for a separate patchset. >> > > Where would you put the state if you were preempted? You want to > allocate a full extra buffer for the kernel xstate for each thread just > in case? ("Yes" is a valid answer to that question, but it is a fair > chunk of memory.)
kernel_fpu_begin() could receive a pointer to a struct fpu, with fpu->state either preallocated by the caller, or allocated by kernel_fpu_begin() itself.
-- error compiling committee.c: too many arguments to function
| |