Messages in this thread | | | Subject | Re: [PATCH] Staging: panel: Fixed a macro coding style issue | From | Joe Perches <> | Date | Wed, 19 Sep 2012 12:44:58 -0700 |
| |
On Thu, 2012-09-20 at 01:07 +0530, Adil Mujeeb wrote: > Removed do {} while (0) loop for a single statement macros > > Signed-off-by: Adil Mujeeb <mujeeb.adil@gmail.com> > --- > linux-3.6-rc6/drivers/staging/panel/panel.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-3.6-rc6/drivers/staging/panel/panel.c b/linux-3.6-rc6/drivers/staging/panel/panel.c > index 39f9982..d9fec5b 100644 > --- a/linux-3.6-rc6/drivers/staging/panel/panel.c > +++ b/linux-3.6-rc6/drivers/staging/panel/panel.c > @@ -137,8 +137,8 @@ > #define r_ctr(x) (parport_read_control((x)->port)) > #define r_dtr(x) (parport_read_data((x)->port)) > #define r_str(x) (parport_read_status((x)->port)) > -#define w_ctr(x, y) do { parport_write_control((x)->port, (y)); } while (0) > -#define w_dtr(x, y) do { parport_write_data((x)->port, (y)); } while (0) > +#define w_ctr(x, y) (parport_write_control((x)->port, (y))) > +#define w_dtr(x, y) (parport_write_data((x)->port, (y)))
Unnecessary parentheses too. It might be better to use static inlines instead.
| |