lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] block: make struct block_device cacheline_aligned


On Wed, 19 Sep 2012, Jeff Moyer wrote:

> Jeff Moyer <jmoyer@redhat.com> writes:
>
> > Hi,
> >
> > When testing against a pcie ssd or a ramdisk, making the block device
> > structure cacheline_aligned provided a significant increase in
> > performance:
>
> Self-NACK on this one. This results in a ton of warnings:
>
> include/linux/fs.h:727: warning: ???__section__??? attribute does not
> apply to types
> In file included from include/linux/debugfs.h:18,
> from kernel/trace/trace_probe.h:28,
> from kernel/trace/trace_kprobe.c:23:
> include/linux/fs.h:727: warning: ???__section__??? attribute does not
> apply to types
>
> And that leaves me with the task of figuring out if/why this actually
> helps.
>
> Cheers,
> Jeff

Hi

Use ____cacheline_aligned instead of __cacheline_aligned

Mikulas


\
 
 \ /
  Last update: 2012-09-19 17:41    [W:0.065 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site