lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] compat: fs: Generic compat_sys_sendfile implementation
On 18 September 2012 19:13, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 18 September 2012, Catalin Marinas wrote:
>> @@ -229,7 +229,7 @@ COMPAT_SYS_SPU(sched_setaffinity)
>> COMPAT_SYS_SPU(sched_getaffinity)
>> SYSCALL(ni_syscall)
>> SYSCALL(ni_syscall)
>> -SYS32ONLY(sendfile64)
>> +SYS32ONLY(sendfile64_wrapper)
>> COMPAT_SYS_SPU(io_setup)
>> SYSCALL_SPU(io_destroy)
>> COMPAT_SYS_SPU(io_getevents)
>
> I believe this will break native ppc32 builds because there is
> no sys_sendfile64_wrapper function. You probably have to use
>
> SYSX(sys_ni_syscall, compat_sys_sendfile64_wrapper, sys_sendfile64)

OK, I only built ppc64. I made this change and I'll re-post the patch.

What I've noticed on ppc64 is that __NR_sendfile is routed to
sys_sendfile64(). I'm changing this to sys_sendfile() as I don't see
why we need to carry the two almost identical functions around:

-SYSX_SPU(sys_sendfile64,compat_sys_sendfile,sys_sendfile)
+SYSX_SPU(sys_sendfile,compat_sys_sendfile_wrapper,sys_sendfile)

--
Catalin


\
 
 \ /
  Last update: 2012-09-19 13:21    [W:0.047 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site