lkml.org 
[lkml]   [2012]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH part2 6/6] PCI: Claim hw/fw allocated resources in hot add path.
    From
    On Mon, Sep 17, 2012 at 9:44 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Mon, Sep 17, 2012 at 5:12 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
    >> On Sun, Sep 2, 2012 at 3:50 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    >
    >>> -static void __init pcibios_allocate_bridge_resources(struct pci_dev *dev)
    >>> +static void pcibios_allocate_bridge_resources(struct pci_dev *dev)
    >>
    >> This patch has a little too much going on at the same time. Can you
    >> split the __init removal into its own patch so we can focus on what's
    >> left by itself?
    >
    > ok.
    >
    >>
    >>> {
    >>> int idx;
    >>> struct resource *r;
    >>>
    >>> for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
    >>> r = &dev->resource[idx];
    >>> + if (r->parent) /* Already allocated */
    >>> + continue;
    >>
    >> This is also a potentially interesting change that maybe should be in
    >> its own patch.
    >
    > oh, we don't need that extra checking anymore. because support
    > removing non-root bus is dropped.

    I updated for-pci-root-bus-hotplug-part2.

    http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-root-bus-hotplug-part2

    Thanks

    Yinghai


    \
     
     \ /
      Last update: 2012-09-18 08:21    [W:4.124 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site