Messages in this thread | | | From | Seungwon Jeon <> | Subject | RE: [PATCH v2 1/4] drivers/mmc/host/dw_mmc.c: fix error return code | Date | Tue, 18 Sep 2012 19:13:47 +0900 |
| |
On Monday, September 17, 2012, Peter Senna Tschudin <peter.senna@gmail.com> wrote: > From: Peter Senna Tschudin <peter.senna@gmail.com> > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Looks good. Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
> -- > 1.7.11.4
| |