lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] misc/at25: Add an .id_table to at25 to facilitate driver loading and binding.
On 09/17/2012 12:49 AM, Ivo Sieben wrote:
> Hi,
>
> 2012/8/22 David Daney <ddaney.cavm@gmail.com>:
>> From: David Daney <david.daney@cavium.com>
>>
>> /*-------------------------------------------------------------------------*/
>> +static const struct spi_device_id at25_id[] = {
>> + {"at25", 0},
>> + {"m95256", 0},
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(spi, at25_id);
>
> I use this driver for the ST M95040, M95020 & M95010 eeprom devices.
> So wouldn't it be better to use the "famliy" name for these chips
> ("m95" instead of "m95256").
>

These are matched against device tree compatible properties. You could
propose adding a generic "st,95xxx" compatible property and adding that
to the at25_id list. But I don't think we want to remove "m95256", as
we have deployed devices using this binding.

David Daney



\
 
 \ /
  Last update: 2012-09-17 19:41    [W:0.064 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site