lkml.org 
[lkml]   [2012]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/5] KVM: MMU: introduce page_fault_start and page_fault_end
    On Fri, Sep 14, 2012 at 05:59:06PM +0800, Xiao Guangrong wrote:
    > Wrap the common operations into these two functions
    >
    > Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>

    Why? I think people are used to

    spin_lock(lock)
    sequence
    spin_unlock(lock)

    So its easy to verify whether access to data structures are protected.

    Unrelated to this patch, one opportunity i see to simplify this
    code is:

    - error pfn / mmio pfn / invalid pfn relation

    Have the meaning of this bits unified in a single function/helper, see
    comment to patch 1 (perhaps you can further improve).



    \
     
     \ /
      Last update: 2012-09-15 18:21    [W:2.448 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site