Messages in this thread | | | Date | Wed, 12 Sep 2012 11:11:27 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings |
| |
On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote: > From: J Keerthy <j-keerthy@ti.com> > > Removes checkpatch warnings on omap-bandgap.c. >
Which checkpatch.pl warnings?
> + omap_bandgap_writel(bg_ptr, > + rval->tshut_threshold, > + tsr->tshut_threshold);
That's just whacky.
Personally, I've never cared much about long lines, so I'd prefer to leave these as is until someone can break the functions up and remove them in a proper way instead of just shifting everything randomly to the left.
regards, dan carpenter
| |