Messages in this thread | | | Date | Wed, 12 Sep 2012 09:41:02 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them |
| |
Hello,
On Wed, Sep 12, 2012 at 05:47:45PM +0200, Michal Hocko wrote: > > If it's absolutely necessary, I think it should be a root-only flag > > (even if that ends up using the same code path). Eventually, we > > really want to kill .use_hierarchy, or at least make it to RO 1. As > > it's currently defined, it's just way too confusing. > > Agreed on that, definitely.
The thing is that if we're gonna be headed that way, we're gonna have to nudge people to .use_hierarchy = 1 everywher first. If .use_hierarchy = 0 at root is a valid use case which absolutedly needs to be maintained (from what I read, I don't think it is), let's move it to a different root-only flag; otherwise, it should be phased out. As such, while the user might not be necessarily wrong, we still need to unify the behavior, I think.
Thanks.
-- tejun
| |