| Date | Tue, 11 Sep 2012 16:23:19 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3 6/9] ARM: mvebu: add pinctrl device in DT for Armada 370/XP SoCs |
| |
On 09/10/2012 02:39 AM, Sebastian Hesselbarth wrote: > From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > The Armada 370 and XP SoCs have configurable muxing for a certain > number of their pins, controlled through a pinctrl driver.
Hmmm. I'd be tempted just to put the entire node definition there; putting in a .dtsi file just to share the reg property doesn't seem especially useful.
> The 'compatible' property is defined in the SoC-specific .dtsi files, > since the compatible string identifies the number of pins and other > SoC-specific properties.
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> + pinctrl@d0018000 {
If this is the only pinctrl instance, you'd typically name the node just "pinctrl", since the "@d0018000" isn't needed to get unique node names.
> + reg = <0xd0018000 0x38>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges;
What is "ranges" for; this isn't a memory-mapped bus, right?
> + }; > }; > };
|