lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [ 12/95] xhci: Switch PPT ports to EHCI on shutdown.
From
Date
On Mon, 2012-09-10 at 14:09 +0300, Denis Turischev wrote:
> Hi Ben,
>
> As reported by Robert Hancock there is a typo in if statement below.
> Do you want I resubmit it? Or should we wait for Sarah Sharp review?
[...]
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -648,6 +648,9 @@ void xhci_shutdown(struct usb_hcd *hcd)
> > {
> > struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> >
> > + if (xhci->quirks && XHCI_SPURIOUS_REBOOT)
>
>
> This looks like a typo, think it should be & not &&. With this code, it
> appears the quirk will always be triggered since XHCI_SPURIOUS_REBOOT is
> non-zero.
[...]

As the typo is not fixed in mainline, I can't fix it in 3.2.y yet. So
I'll defer this until that happens.

Thanks for your review.

Ben.

--
Ben Hutchings
Make three consecutive correct guesses and you will be considered an expert.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-09-10 18:02    [W:0.544 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site