Messages in this thread | | | Date | Thu, 9 Aug 2012 10:13:56 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step |
| |
On Wed, Aug 08, 2012 at 04:53:45PM +0200, Oleg Nesterov wrote: > On 08/08, Sebastian Andrzej Siewior wrote:
...
> >> ->insn[0] doesn't look right, we should skip the prefixes.
insn_init() insn_get_opcode() if (OPCODE1() == 0x9d)
is always the right way of doing it.
...
> And in any case it would be better to re-use auprobe->fixups.
Agreed.
Ananth
| |