lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/19] mm/mpol: Remove NUMA_INTERLEAVE_HIT
Date
Andrea Arcangeli <aarcange@redhat.com> writes:

> Hi,
>
> On Tue, Jul 31, 2012 at 09:12:06PM +0200, Peter Zijlstra wrote:
>> Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants
>> to be compared to either a total of interleave allocations or to a miss
>> count, remove it.
>>
>> Fixing it would be possible, but since we've gone years without these
>> statistics I figure we can continue that way.
>>
>> Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users might
>> switch to using that.
>>
>> This cleans up some of the weird MPOL_INTERLEAVE allocation exceptions.
>
> It's not apparent why you need to remove it for sched-numa. I think I
> see it but it'd be nicer if it would explained so one doesn't need to
> read an internal bit of several patches later to understand why this
> is needed.

Also it still breaks the numactl test suite, as already explained
multiple times. Without the HIT counter there is no way to check
interleave actually happened.

I'm a bit concerned about patch kits like this ignoring review feedback?

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2012-08-10 03:41    [W:0.154 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site