Messages in this thread Patch in this message | | | From | Cody P Schafer <> | Subject | [PATCH 07/16] perf symbol: symplify out_fixup in kernel syms loading | Date | Thu, 9 Aug 2012 15:18:32 -0700 |
| |
The only site that jumps to out_fixup has (kallsyms_filename == NULL). And all paths that reach 'if (err > 0)' without 'goto out_fixup' have kallsyms_filename != NULL.
So skip over both the check & dso__set_long_name(), and remove the check.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> --- tools/perf/util/symbol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index caab61a..90d2760 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -2303,9 +2303,8 @@ do_kallsyms: free(kallsyms_allocated_filename); if (err > 0) { + dso__set_long_name(dso, strdup("[kernel.kallsyms]")); out_fixup: - if (kallsyms_filename != NULL) - dso__set_long_name(dso, strdup("[kernel.kallsyms]")); map__fixup_start(map); map__fixup_end(map); } -- 1.7.11.3
| |