Messages in this thread | | | Date | Wed, 8 Aug 2012 23:30:05 -0700 | Subject | Re: [PATCH v5 03/12] block: Add bio_reset() | From | Tejun Heo <> |
| |
Hello,
On Wed, Aug 8, 2012 at 11:06 PM, Kent Overstreet <koverstreet@google.com> wrote: > On Wed, Aug 08, 2012 at 11:00:19PM -0700, Tejun Heo wrote: >> Anyways, understood. Can you *please* put some comment what bits are >> being preserved across reset then? Things like this aren't obvious at >> all and need ample explanation. > > I did, in the header: > > #define BIO_RESET_BITS 12 /* Flags starting here get preserved by > bio_reset() */ > > Where the rest of the flags are defined, and near where BIO_RESET_BYTES > are defined.
Yeah, I was hoping for the comment to note that the protected bits include the pool index.
Thanks.
-- tejun
| |