Messages in this thread | | | Date | Thu, 9 Aug 2012 19:13:33 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/3] perf tools: Initial bash completion support |
| |
On Thu, Aug 09, 2012 at 02:11:22PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 09, 2012 at 07:00:10PM +0200, Frederic Weisbecker escreveu: > > On Thu, Aug 09, 2012 at 01:35:15PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Aug 09, 2012 at 04:31:51PM +0200, Frederic Weisbecker escreveu: > > > > This implements bash completion for perf subcommands such > > > > as record, report, script, probe, etc... > > > > > > Humm, I get this when doing my usual workflow: > > > > > > [acme@sandy linux]$ make -j8 -C tools/perf/ O=/home/acme/git/build/perf install > > > make: Entering directory `/home/git/linux/tools/perf' > > > PERF_VERSION = 3.6.rc1.152.g5758f7 > > > <SNIP> > > > install -d -m 755 '/home/acme/libexec/perf-core/scripts/python/Perf-Trace-Util/lib/Perf/Trace' > > > install -d -m 755 '/home/acme/libexec/perf-core/scripts/python/bin' > > > install scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '/home/acme/libexec/perf-core/scripts/python/Perf-Trace-Util/lib/Perf/Trace' > > > install scripts/python/*.py -t '/home/acme/libexec/perf-core/scripts/python' > > > install scripts/python/bin/* -t '/home/acme/libexec/perf-core/scripts/python/bin' > > > install -m 755 bash_completion /etc/bash_completion.d/perf > > > install: cannot create regular file `/etc/bash_completion.d/perf': Permission denied > > > make: *** [install] Error 1 > > > make: Leaving directory `/home/git/linux/tools/perf' > > > [acme@sandy linux]$ make -j8 -C tools/perf/ O=/home/acme/git/build/perf install > > > > > > Shouldn't it install on ~/etc/bash_completion.d/perf ? > > > > Are you sure you have the third patch? > > So should I fold the third into the first?
That's up to you. I kept the third patch seperate to let the credit to Namhyung.
> > > > > > > Is there a way to have per user bash completion files like that? > > > > It seems that some manual tweaking is needed :( > > > > http://www.simplicidade.org/notes/archives/2008/02/bash_completion.html > > Will read. > > - Arnaldo
| |