Messages in this thread | | | Date | Thu, 9 Aug 2012 15:50:05 +0100 | From | Dave Martin <> | Subject | Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2_KERNEL build breakage |
| |
On Thu, Aug 09, 2012 at 09:32:59AM -0500, Matt Sealey wrote: > Matt Sealey <matt@genesi-usa.com> > Product Development Analyst, Genesi USA, Inc. > > > On Thu, Aug 9, 2012 at 5:24 AM, Dave Martin <dave.martin@linaro.org> wrote: > > On Wed, Aug 08, 2012 at 12:32:39PM -0500, Matt Sealey wrote: > > > > [...] > > > >> I'm going to do a trapse through and find where Russell nacked Dave's > >> thumb-aware > >> rewrite.. would you mind if you have any of these boards seeing if it > >> really DOES > > > > There was no NAK because I didn't get as far as posting the patch, > > http://lists.arm.linux.org.uk/lurker/message/20111202.133911.393b6e28.en.html > > You did, twice :)
Well, I meant that I had not posted it as a stand-alone patch for inclusion; I only posted it when commenting on other threads.
> > mostly because of the doubt about whether this code is ever relevant > > on Thumb2-capable hardware. > > It's not, but it does break the build, and without disabling phyCORE boards for > Thumb2 it will always break the build..
If you want me to push it, let me know. I don't think this should get merged without some Tested-bys for hardware where the FIQ stuff actually gets used.
The older post would be the one to use, since that at least got a reasonable level of build testing.
Cheers ---Dave
| |