Messages in this thread | | | Date | Thu, 9 Aug 2012 11:09:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH V2 1/3] regulator: add always set/clear masks to regulator_enable_regmap |
| |
On Wed, Aug 08, 2012 at 03:18:45PM -0600, Stephen Warren wrote:
> + rdev->desc->enable_mask | > + rdev->desc->en_dis_set_mask | > + rdev->desc->en_dis_clr_mask, > + rdev->desc->enable_mask | > + rdev->desc->en_dis_set_mask);
Two problems here. One is that the names are *really* obscure and hard to read, the other is that this breaks all existing users.
| |