lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/3] regulator: add always set/clear masks to regulator_enable_regmap
On Wed, Aug 08, 2012 at 03:18:45PM -0600, Stephen Warren wrote:

> + rdev->desc->enable_mask |
> + rdev->desc->en_dis_set_mask |
> + rdev->desc->en_dis_clr_mask,
> + rdev->desc->enable_mask |
> + rdev->desc->en_dis_set_mask);

Two problems here. One is that the names are *really* obscure and hard
to read, the other is that this breaks all existing users.


\
 
 \ /
  Last update: 2012-08-09 12:43    [W:0.088 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site