Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings | Date | Thu, 9 Aug 2012 11:27:02 +0200 |
| |
On Thursday, August 09, 2012, Thierry Reding wrote: > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will > complain about them being unused. > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
The pm_no_operation() thing is not necessary at all, AFAICT. I'd just remove it entirely. :-)
Thanks, Rafael
> --- > drivers/mmc/core/sdio_bus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c > index 236842e..f8f90b4 100644 > --- a/drivers/mmc/core/sdio_bus.c > +++ b/drivers/mmc/core/sdio_bus.c > @@ -193,11 +193,12 @@ static int sdio_bus_remove(struct device *dev) > } > > #ifdef CONFIG_PM > - > +#ifdef CONFIG_PM_SLEEP > static int pm_no_operation(struct device *dev) > { > return 0; > } > +#endif > > static const struct dev_pm_ops sdio_bus_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(pm_no_operation, pm_no_operation) >
| |