Messages in this thread | | | Date | Wed, 8 Aug 2012 08:35:19 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots |
| |
> Restating my comment elsewhere... why do we even need to do this in > _get_virq() - I'd *really* expect this to be handled by the irq domain > code.
> > Okay, so I've just spent a small amount of time looking at this. I think > > the best place for this would be in *_get_virq(), using the same logic that > > selected a *_legacy or *_linear domain in the first place.
> I'd expect your driver to always pass a hwirq into _get_virq() here.
I actually had this thought last night.
(I really must learn to switch off in the evenings.) ;)
That's even easier then. I'll make the changes and submit.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |