| Date | Wed, 8 Aug 2012 16:30:07 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v5 12/12] block: Only clone bio vecs that are in use |
| |
Hello,
On Mon, Aug 06, 2012 at 03:08:41PM -0700, Kent Overstreet wrote: > @@ -459,10 +460,10 @@ void __bio_clone(struct bio *bio, struct bio *bio_src) > bio->bi_sector = bio_src->bi_sector; > bio->bi_bdev = bio_src->bi_bdev; > bio->bi_flags |= 1 << BIO_CLONED; > + bio->bi_flags &= ~(1 << BIO_SEG_VALID);
This isn't obvious at all. Why no explanation anywhere? Also it would be nice to update comments of the updated functions so that it's clear that only partial cloning happens.
Thanks.
-- tejun
|