Messages in this thread | | | Date | Wed, 8 Aug 2012 17:09:20 -0400 | Subject | Re: NULL pointer dereference in selinux_ip_postroute_compat | From | Eric Paris <> |
| |
On Wed, Aug 8, 2012 at 5:03 PM, Paul Moore <paul@paul-moore.com> wrote: > On Wednesday, August 08, 2012 04:51:56 PM Eric Paris wrote:
>> Could we add a __init function which does the security_sk_alloc() in >> the same file where we declared them? > > Is it safe to call security_sk_alloc() from inside another __init function? I > think in both the case of SELinux and Smack it shouldn't be a problem, but I'm > concerned about the more general case of calling a LSM hook potentially before > the LSM has been initialized. > > If that isn't an issue we could probably do something in ip_init().
The security_initcall() functions should happen way before __init functions. If an LSM busts, it's the LSM initializing itself too late not the code here being wrong...
| |