Messages in this thread | | | Date | Wed, 8 Aug 2012 16:37:57 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 18/41] TTY: pty, switch to tty_alloc_driver |
| |
On Tue, 7 Aug 2012 21:47:43 +0200 Jiri Slaby <jslaby@suse.cz> wrote:
> Switch to the new driver allocation interface, as this is one of the > special call-sites. Here, we need TTY_DRIVER_EXCESSIVE_LINES to not > allocate tty_driver->ports, cdevs and potentially other structures > because we reserve too many lines in pty. Instead, it provides the > tty_port<->tty_struct link in tty->ops->install already.
This is the only thing I would quibble about in the entire patch set.
We've got a pile of things that the pty does and one or two other drivers might want to do about dynamic allocation (termios objects is the same problem).
I think it's a mistake to call it EXCESSIVE_LINES, better a name which indicates what it implies - say TTY_DRIVER_DYNAMIC_ALLOC. Then it means other drivers can move that way if they wish.
Otherwise
Acked-by: Alan Cox <alan@linux.intel.com>
for the entire series, and next time we are both at the same conference I owe you a a couple of beers at least !
| |